[Pipe] Preserve parser fairness and OOM retry state#18306
Open
Caideyipi wants to merge 1 commit into
Open
Conversation
Caideyipi
force-pushed
the
fix/pipe-parser-fairness-retry-dev-1.3
branch
from
July 25, 2026 08:29
0362574 to
1db7dfc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #18305 to
dev/1.3.The fair TsFile parser admission prerequisite has landed in
dev/1.3through #18295. This PR is rebased on that commit and now contains only the follow-up fix.Preserve fairness across temporary queue gaps
The TsFile parser scheduler removed a single-region Pipe from the waiting order after admitting its only pending request. If that Pipe re-entered while a multi-region Pipe still had queued requests, queue insertion order could give the multi-region Pipe consecutive admissions. This change keeps a pipe-level admission cursor across temporary gaps, advances it only for requests that actually waited, and clears it once parser reservations and waiters are both idle.
Preserve scan parser state on critical OOM
A critical OOM while resizing memory for the next Tablet was handled by the generic exception path, which closed the scan parser even though the current data had not been consumed. The scan container now propagates this retryable OOM without closing so the caller can yield the parser slot and retry from the same iterator position. Other exceptions retain the existing close-and-wrap behavior.
This also preserves the two parser diagnostics required by the V1-498 test procedure:
failed to consume parsed tablet from TsFilefailed to allocate memory for parsing TsFileVerification
.\mvnw.cmd clean test -pl iotdb-core/datanode -am '-Dtest=PipeMemoryManagerTest,TsFileInsertionDataContainerTest' '-Dsurefire.failIfNoSpecifiedTests=false' '-DskipITs' '-Ddevelocity.off=true'This PR has:
Key changed/added classes
PipeMemoryManagerPipeTsFileInsertionEventTsFileInsertionScanDataContainerPipeMemoryManagerTestTsFileInsertionDataContainerTest